Skip to content

Commit

Permalink
Update FLUTTER_NOLINT uses to include issue link (flutter#21921)
Browse files Browse the repository at this point in the history
In an upcoming patch, we'll enable enforcement that all FLUTTER_NOLINT
comments include an issue link. This migrates the remaining uses to that
format.

Bug: flutter#68273
  • Loading branch information
cbracken committed Oct 16, 2020
1 parent 04bf879 commit b8fd001
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 0 additions & 4 deletions shell/platform/linux/fl_json_message_codec.cc
Expand Up @@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(cbracken): lint disabled due to rapidjson null deref issue.
// https://github.com/flutter/flutter/issues/65676
// FLUTTER_NOLINT

#include "flutter/shell/platform/linux/public/flutter_linux/fl_json_message_codec.h"

#include <gmodule.h>
Expand Down
3 changes: 2 additions & 1 deletion shell/version/version.cc
@@ -1,7 +1,8 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// FLUTTER_NOLINT

// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68332

#include "flutter/shell/version/version.h"

Expand Down
3 changes: 2 additions & 1 deletion vulkan/vulkan_window.cc
@@ -1,7 +1,8 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// FLUTTER_NOLINT

// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68331

#include "vulkan_window.h"

Expand Down

0 comments on commit b8fd001

Please sign in to comment.