Skip to content

Commit

Permalink
Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VU…
Browse files Browse the repository at this point in the history
…LKAN} (flutter#21603)
  • Loading branch information
George Wright committed Oct 6, 2020
1 parent 042c7f0 commit ea420db
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions shell/common/BUILD.gn
Expand Up @@ -144,14 +144,6 @@ template("shell_host_executable") {
}

if (enable_unittests) {
config("test_enable_gl_config") {
defines = [ "SHELL_ENABLE_GL" ]
}

config("test_enable_vulkan_config") {
defines = [ "SHELL_ENABLE_VULKAN" ]
}

shell_gpu_configuration("shell_unittests_gpu_configuration") {
enable_software = test_enable_software
enable_vulkan = test_enable_vulkan
Expand Down Expand Up @@ -217,7 +209,10 @@ if (enable_unittests) {
"//third_party/skia",
]

public_configs = [ ":shell_test_fixture_sources_config" ]
public_configs = [
":shell_test_fixture_sources_config",
":shell_unittests_gpu_configuration_config",
]

# SwiftShader only supports x86/x64_64
if (target_cpu == "x86" || target_cpu == "x64") {
Expand All @@ -227,8 +222,6 @@ if (enable_unittests) {
"shell_test_platform_view_gl.h",
]

public_configs += [ ":test_enable_gl_config" ]

public_deps += [ "//flutter/testing:opengl" ]
}
}
Expand All @@ -239,8 +232,6 @@ if (enable_unittests) {
"shell_test_platform_view_vulkan.h",
]

public_configs += [ ":test_enable_vulkan_config" ]

public_deps += [ "//flutter/vulkan" ]
}
}
Expand Down

0 comments on commit ea420db

Please sign in to comment.