Skip to content

Commit

Permalink
Preliminary PR for engine changes for Tristate checkboxes (#110859)
Browse files Browse the repository at this point in the history
* Honor mixed state

* Prepare for change to engine

* Unused vars

* Remove comments

* Skip test for now

* Comment for skip

* Compartmentalize changes

* Justification comments
  • Loading branch information
yaakovschectman committed Sep 6, 2022
1 parent 632c353 commit 96b7223
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/flutter/test/widgets/custom_painter_test.dart
Expand Up @@ -519,7 +519,7 @@ void _defineTests() {
);
expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true));
semantics.dispose();
});
}, skip: true); // [intended] https://github.com/flutter/flutter/issues/110107

group('diffing', () {
testWidgets('complains about duplicate keys', (WidgetTester tester) async {
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter/test/widgets/semantics_test.dart
Expand Up @@ -632,7 +632,7 @@ void main() {

expect(semantics, hasSemantics(expectedSemantics, ignoreId: true));
semantics.dispose();
});
}, skip: true); // [intended] https://github.com/flutter/flutter/issues/110107

testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester);
Expand Down

0 comments on commit 96b7223

Please sign in to comment.