Add a function to only freeze (if enabled)

[geirsagberg]

When using seamless-immutable, I usually do Immutable.from(result) for all my AJAX-calls, so I am sure it will not be changed further down the line.

It would be nice to have a similar function for ImmutableAssign, that would Object.Freeze if enabled, otherwise it would do nothing.

Example:

const immutableResult = iassign(result)

[JiriZidek]

Feel free to use DeepFreeze instead...

[geirsagberg]

I did something like this:

import iassign from 'immutable-assign'
import DeepFreeze from 'deep-freeze'

export const deepFreeze = obj => iassign.freeze ? DeepFreeze(obj) : obj

Would you be opposed to a PR with such a wrapper included in ImmutableAssign?

[JiriZidek]

Why create dependency on DeepFreeze, when benefit (freezing is usefull for developer only, in production it is no-no) is so small ? Moreover you can add such trival wrapper to your project as single function without forcing all consumers of iassign to bloat their code with DeepFreeze?

[JiriZidek]

Now I see that DeepFreeze is in current version required anyway...

[engineforce]

Hi geirsagberg, I am not a fan of re-exporting of another module, which is antipattern. The better way is that you create your own module (called immutable-util for example), which export iassign() and deepFreeze(). And make your application codes depending on the new module, so you can swap out iassign() in the future if needed.

[geirsagberg]

That's good advice, I might just do that. Thanks!

…

On Sat, Aug 12, 2017, 03:55 Paul Li ***@***.***> wrote: Hi geirsagberg, I am not a fan of re-exporting of another module, which is antipattern. The better way is that you create your own module (called immutable-util for example), which export iassign() and deepFreeze(). And make your application codes depending on the new module, so you can swap out iassign() in the future if needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAkShN8fnRgfQ07RtqPKYQQOTULhgw87ks5sXQX4gaJpZM4O0rvJ> .