Skip to content

Commit

Permalink
Use --instance-roles instead of --instance_roles.
Browse files Browse the repository at this point in the history
Same for --instance-names.

engineyard-serverside doesn't parse the arguments correctly when they
have underscores in them.
  • Loading branch information
smerritt committed Sep 10, 2010
1 parent e29157f commit 21c142a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/engineyard/model/instance.rb
Expand Up @@ -120,10 +120,10 @@ def invoke_engineyard_serverside(deploy_args, verbose=false)
instance_args << '--instances'
instance_args += instances.collect { |i| i.public_hostname }

instance_args << '--instance_roles'
instance_args << '--instance-roles'
instance_args += instances.collect { |i| [i.public_hostname, i.role].join(':') }

instance_args << '--instance_names'
instance_args << '--instance-names'
instance_args += instances.collect { |i| i.name ? [i.public_hostname, i.name].join(':') : nil }.compact
end

Expand Down
4 changes: 2 additions & 2 deletions spec/support/shared_behavior.rb
Expand Up @@ -151,8 +151,8 @@ def make_scenario(hash)
it "passes along instance information to engineyard-serverside" do
instance_args = [
/--instances app_master[^\s]+ app_hostname[^\s]+ util_fluffy/,
/--instance_roles app_master[^\s]+:app_master app_hostname[^\s]+:app util_fluffy[^\s]+:util/,
/--instance_names util_fluffy[^\s]+:fluffy/
/--instance-roles app_master[^\s]+:app_master app_hostname[^\s]+:app util_fluffy[^\s]+:util/,
/--instance-names util_fluffy[^\s]+:fluffy/
]

db_instance = /db_master/
Expand Down

0 comments on commit 21c142a

Please sign in to comment.