Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniform map in the GraphicsProgram should not be holding pointers #124

Open
enginmanap opened this issue Oct 12, 2020 · 1 comment
Open
Assignees

Comments

@enginmanap
Copy link
Owner

Pointers are creating another indirection in the hot path, which is not providing any benefits, so should be eliminated.

@enginmanap
Copy link
Owner Author

This is even worse. Since I am using String names to access them, it causes allocations, and it is like 10th highest CPU user in a profile, just to get the names. Material editor should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants