Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 adds support for @external keyword #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamiehowarth0
Copy link

No description provided.

@englercj
Copy link
Owner

englercj commented Dec 1, 2019

I think this will allow code that uses @external to successfully parse, but the typescript it outputs will be incorrect and potentially disruptive when used in other projects.

For example, this makes @external jQuery generate declare class jQuery {}. If someone includes a def file for jQuery, it will also have declare class jQuery {} which I think will cause an error.

This is why I mention in the readme that I'm not sure what the right behavior for this tag is, and therefore left it unimplemented. I think the only "correct" thing it could do would be to import the external and use the definitions defined elsewhere by the import. However, I don't even think that works for all environments people use this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants