Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Handling Callbacks #3

Merged
merged 5 commits into from
Oct 11, 2017
Merged

Event Handling Callbacks #3

merged 5 commits into from
Oct 11, 2017

Conversation

gemmadlou
Copy link
Contributor

So when the iframe is loaded, opened or created, a callback can be connected via the constructor.

englishextra
englishextra reviewed Oct 11, 2017
View reviewed changes
Copy link
Owner

@englishextra englishextra left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two warnings

25 | 'options' is already defined. (remove var)
144 | Missing semicolon.

@englishextra
Copy link
Owner

@gemmadlou Thanks

@englishextra englishextra merged commit 43d246e into englishextra:master Oct 11, 2017
@englishextra englishextra mentioned this pull request Oct 11, 2017
Closed
@gemmadlou
Copy link
Contributor Author

Thanks for merging that in @englishextra. That's awesome. And thanks for your code.

englishextra added a commit that referenced this pull request Oct 11, 2017
@englishextra
Update iframe-lightbox.min.js
e629c4e 
as of #3
@englishextra
Copy link
Owner

@gemmadlou Likewise. I updated https://github.com/englishextra/iframe-lightbox/blob/master/iframe-lightbox.min.js

@gemmadlou
Copy link
Contributor Author

Sorry for missing that

@englishextra
Copy link
Owner

@gemmadlou no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englishextra englishextra englishextra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gemmadlou @englishextra