Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room Background Stretched Bug #1712

Closed
RobertBColton opened this issue May 11, 2019 · 3 comments · Fixed by #1713
Closed

Room Background Stretched Bug #1712

RobertBColton opened this issue May 11, 2019 · 3 comments · Fixed by #1713
Labels
Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Room Editor Placement of instances and tiles and configuration of views, backgrounds, and scene settings.

Comments

@RobertBColton
Copy link
Contributor

RobertBColton commented May 11, 2019 •
edited

Hugar is having issues with stretching a background to fill a room. From what I can see, the stretched option is implemented the same as GM8.1, by which I mean it modifies the background_xscale/background_yscale variables.
@RobertBColton RobertBColton added Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Room Editor Placement of instances and tiles and configuration of views, backgrounds, and scene settings. labels May 11, 2019
@RobertBColton RobertBColton changed the title Room Background Stretched Unimplemented Room Background Stretched Bug May 11, 2019
@RobertBColton
Copy link
Contributor Author

RobertBColton commented May 11, 2019 •
edited

Found it, was a typo, we were passing xscale for the yscale. I don't know how this went unnoticed for so long.

enigma-dev/ENIGMAsystem/SHELL/Graphics_Systems/General/GSscreen.cpp

Line 88 in 0dd36ef

draw_background_ext(background_index[back_current], background_x[back_current], background_y[back_current], background_xscale[back_current], background_xscale[back_current], 0, background_coloring[back_current], background_alpha[back_current]);

@RobertBColton RobertBColton mentioned this issue May 11, 2019
Merged
@RobertBColton
Copy link
Contributor Author

RobertBColton commented May 11, 2019 •
edited

This was not a regression and had existed since polygonz first added it.
74b374c#diff-e8d65b527616f03e73a909a01ff9b3f6R53

@RobertBColton
Copy link
Contributor Author

Closing as resolved by #1713.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Room Editor Placement of instances and tiles and configuration of views, backgrounds, and scene settings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Room Background Y Scale enigma-dev/enigma-dev
1 participant
@RobertBColton