upgrade_build_system_to_cmake #2314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fundies
requested changes
Jul 23, 2022
fundies
reviewed
Dec 5, 2022
shared/protos/Makefile
Outdated
| @@ -2,7 +2,8 @@ include ../../Config.mk | |||
|
|
|||
| PROTO_SOURCES := $(wildcard *.proto) $(wildcard Configuration/*.proto) | |||
| SOURCES_GRPC := server.proto | |||
| LDFLAGS += -lgrpc++ | |||
| LDFLAGS += -DNOMINMAX -maes -msse4.1 -DNOMINMAX -maes -msse4.1 -DNOMINMAX -IC:/msys64/mingw64/include -LC:/msys64/mingw64/lib -lgrpc++ -lgrpc -laddress_sorting -lre2 -lupb -lcares -lz -lgpr -lssl -lcrypto -labsl_raw_hash_set -labsl_hashtablez_sampler -labsl_hash -labsl_city -labsl_low_level_hash -labsl_random_distributions -labsl_random_seed_sequences -labsl_random_internal_pool_urbg -labsl_random_internal_randen -labsl_random_internal_randen_hwaes -labsl_random_internal_randen_hwaes_impl -labsl_random_internal_randen_slow -labsl_random_internal_platform -lbcrypt -labsl_random_internal_seed_material -labsl_random_seed_gen_exception -labsl_statusor -labsl_status -labsl_cord -labsl_cordz_info -labsl_cord_internal -labsl_cordz_functions -labsl_exponential_biased -labsl_cordz_handle -labsl_bad_optional_access -labsl_str_format_internal -labsl_synchronization -labsl_graphcycles_internal -labsl_stacktrace -ldbghelp -labsl_symbolize -labsl_debugging_internal -labsl_demangle_internal -labsl_malloc_internal -labsl_time -labsl_civil_time -labsl_strings -labsl_strings_internal -ladvapi32 -labsl_base -labsl_spinlock_wait -labsl_int128 -labsl_throw_delegate -labsl_time_zone -labsl_bad_variant_access -labsl_raw_logging_internal -labsl_log_severity | |||
There was a problem hiding this comment.
this change is unrelated and should be removed
fundies
reviewed
Dec 5, 2022
| @@ -0,0 +1,16 @@ | |||
| set(SDLLIB "sDLLIB") | |||
| set(SDLLIB_DESCRIPTION "SDL Audio System") | |||
| # set(CMAKE_DEBUG_POSTFIX d) | |||
There was a problem hiding this comment.
remove comments if you dont need these lines
.vscode/settings.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
remove these files and add them to .gitignore if you need to
| @@ -0,0 +1,16 @@ | |||
| set(NLIB "noneLIB") | |||
There was a problem hiding this comment.
I'm not a fan of this nameing AUDIO_SYS_NONE instead maybe at very least there should be a an underscore before lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake build system