DEV: failed task output hash; user can verify that eng network output…

[apalepu23]

1. failed task output hash
2. user can verify eng network output matches output hash stored on ethereum

[lenak25]

Thanks @apalepu23.
I've added some comments.
In addition, please add the output hash to the deploySecretContractFailureImpl as well.

[lacabra]

Everything looks good so far, other than the fact that CI breaks now because the P2P is out of sync with the number of parameters that are being passed to CommitTaskFailure, which is to be expected, and that @lenak25 will patch in due time:

p2p_1       | [Thu Sep 12 2019 02:48:36 GMT+0000 (Coordinated Universal Time)] INFO [COMMIT_RECEIPT] success for commitTaskFailure of task eebc2fa94431bd83d354ad3cab16435dc8e25fec9b3440a74564d259e347f28c receipt = [object Promise]
p2p_1       | (node:301) UnhandledPromiseRejectionWarning: Error: Invalid number of parameters for "commitTaskFailure". Got 4 expected 5!

[lenak25]

LGTM

[codecov]

Codecov Report

Merging #141 into develop will decrease coverage by 0.76%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
- Coverage    95.89%   95.12%   -0.77%     
===========================================
  Files            6        6              
  Lines          560      595      +35     
  Branches        52       54       +2     
===========================================
+ Hits           537      566      +29     
- Misses          23       29       +6

Impacted Files	Coverage Δ
enigma-js/src/emitterConstants.js	100% <100%> (ø)	⬆️
enigma-js/src/Enigma.js	94.55% <80.64%> (-1.67%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d66a5...92717dc. Read the comment docs.