-
Notifications
You must be signed in to change notification settings - Fork 7
DEV: failed task output hash; user can verify that eng network output… #141
Conversation
apalepu23
commented
Sep 12, 2019
- failed task output hash
- user can verify eng network output matches output hash stored on ethereum
… matches what's stored on ethereum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apalepu23.
I've added some comments.
In addition, please add the output hash to the deploySecretContractFailureImpl
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good so far, other than the fact that CI breaks now because the P2P is out of sync with the number of parameters that are being passed to CommitTaskFailure
, which is to be expected, and that @lenak25 will patch in due time:
p2p_1 | [Thu Sep 12 2019 02:48:36 GMT+0000 (Coordinated Universal Time)] INFO [COMMIT_RECEIPT] success for commitTaskFailure of task eebc2fa94431bd83d354ad3cab16435dc8e25fec9b3440a74564d259e347f28c receipt = [object Promise]
p2p_1 | (node:301) UnhandledPromiseRejectionWarning: Error: Invalid number of parameters for "commitTaskFailure". Got 4 expected 5!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ess to receipt verified event
Codecov Report
@@ Coverage Diff @@
## develop #141 +/- ##
===========================================
- Coverage 95.89% 95.12% -0.77%
===========================================
Files 6 6
Lines 560 595 +35
Branches 52 54 +2
===========================================
+ Hits 537 566 +29
- Misses 23 29 +6
Continue to review full report at Codecov.
|
BLD: align to contract scrtlabs/enigma-contract#141