Skip to content
This repository has been archived by the owner on Jun 21, 2020. It is now read-only.

BLD: fix issue #218 #228

Merged
merged 3 commits into from
Sep 5, 2019
Merged

BLD: fix issue #218 #228

merged 3 commits into from
Sep 5, 2019

Conversation

lenak25
Copy link
Contributor

@lenak25 lenak25 commented Sep 3, 2019

No description provided.

@lenak25 lenak25 added the not ready Not ready - do not merge yet label Sep 3, 2019
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #228 into develop will increase coverage by 0.24%.
The diff coverage is 76.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #228      +/-   ##
===========================================
+ Coverage    80.22%   80.47%   +0.24%     
===========================================
  Files          109      110       +1     
  Lines         5254     5290      +36     
===========================================
+ Hits          4215     4257      +42     
+ Misses        1039     1033       -6
Impacted Files Coverage Δ
...ntroller/actions/tasks/HandleVerifiedTaskAction.js 100% <100%> (ø)
src/common/constants.js 100% <100%> (ø) ⬆️
src/core/core_server_mock/core_server.js 80.57% <100%> (+2.41%) ⬆️
src/worker/handlers/PrincipalNode.js 91.66% <100%> (+4.16%) ⬆️
src/worker/controller/NodeController.js 80.72% <100%> (+0.21%) ⬆️
...rc/worker/controller/actions/GetStateKeysAction.js 65.3% <25%> (-2.88%) ⬇️
...rker/controller/actions/tasks/ExecuteTaskAction.js 77.27% <66.66%> (ø)
src/worker/tasks/ComputeTask.js 80.55% <0%> (+5.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2e9e9...e73d6f8. Read the comment docs.

@lenak25 lenak25 removed the not ready Not ready - do not merge yet label Sep 4, 2019
AvishaiW
AvishaiW previously approved these changes Sep 5, 2019
Copy link
Contributor

@AvishaiW AvishaiW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/common/constants.js Outdated Show resolved Hide resolved
test/jsonrpc_advanced_test.js Show resolved Hide resolved
@lenak25 lenak25 merged commit 62ea4ef into develop Sep 5, 2019
@lenak25 lenak25 deleted the fix_ptt_race branch September 5, 2019 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants