Fix being unable to type uppercase characters on Windows #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem with Windows being unable to type out uppercase characters when using
Key::Unicode
keys (e.g.Key::Unicode('T')
).Upon using the
key
function that types outUnicode
keys for uppercase characters, the call returns the error below:Apparently the call for
VkKeyScanW
in enigo's code does not handle the uppercase characters: the code is translated into two bytes (as huge comment above the call mentions) as a singleu32
(upperu16
of which isn't used?), which later was not handled and passed over toMapVirtualKeyW
, which fails because it cannot translate two-byte value (e.g.340
for'T'
) into a scancode. This PR handles the two bytes by emitting extra necessary scancodes (e.g.SCANCODE_LSHIFT
) depending on the flags in the high-order byte.P.S. Why does Windows implementation mention keysym in its errors?