Should retry on 4401

[pederbl]

Expected Behaviour
I expected the client to retry connecting after the connection was terminated by the server with a 4401.

Actual Behaviour
But instead the retry is aborted and an error thrown, because the error code was 4401, because of the following code: (

graphql-ws/src/client.ts

Line 834 in 63881c3

CloseCode.Unauthorized,

)

Further Information
Why disable reconnections for 4401 errors? When a token expires it is appropriate for the server to close the connection with a 4401. And, in this case it would be reasonable for the client to refresh the access token and retry the connection.

My workaround now is to send a 4499 instead of 4401, which is bad semantics.

[enisdenjo]

Hey there! The close code 4401 indicates that the client tried subscribing before the handshake's finished (before receiving a ConnectionAck message), meaning there's something wrong with the implementation of the client and should therefore not be retried.

Executing operations is allowed only after the server has acknowledged the connection through the ConnectionAck message, if the connection is not acknowledged, the socket will be closed immediately with the event 4401: Unauthorized.

GraphQL over WebSocket spec

You may be confusing 4401 (Unauthorized) with 4403 (Forbidden), where the latter means that the implementation is OK but the user is not allowed to do something.

[pederbl]

Makes sense. Thanks!