Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Acknowledge connection before notifying the client to avoid race conditions with slow sends #506

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix(server): Acknowledge connection before notifying the client to avoid race conditions with slow sends #506

merged 3 commits into from
Sep 28, 2023

Conversation

enisdenjo
Copy link
Owner

Closes #501

@enisdenjo enisdenjo merged commit 8cb82bd into master Sep 28, 2023
12 checks passed
@enisdenjo enisdenjo deleted the ack-race branch September 28, 2023 17:48
enisdenjo pushed a commit that referenced this pull request Sep 28, 2023
@semantic-release-bot
chore(release): 🎉 5.14.1 [skip ci]
d86f7f7 
## [5.14.1](v5.14.0...v5.14.1) (2023-09-28)

### Bug Fixes

* **server:** Acknowledge connection before notifying the client to avoid race conditions with slow sends ([#506](#506)) ([8cb82bd](8cb82bd)), closes [#501](#501)
@enisdenjo
Copy link
Owner Author

🎉 This PR is included in version 5.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Sep 28, 2023
@enisdenjo enisdenjo mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Has been released and published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server race condition: connection ack + first subscribe
1 participant
@enisdenjo