Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry info to connect events #507

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

telemenar
Copy link
Contributor

This adds retry info to the connecting and connected events. This helps us give the user better status about the current state of their network connection with the websocket.

This adds retry info to the connecting and connected events. This helps
us give the user better status about the current state of their network
connection with the websocket.
Copy link
Owner

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks, would you be so kind and add some tests? Just in case.

@enisdenjo enisdenjo merged commit 9ad853f into enisdenjo:master Feb 12, 2024
enisdenjo pushed a commit that referenced this pull request Feb 12, 2024
# [5.15.0](v5.14.3...v5.15.0) (2024-02-12)

### Bug Fixes

* **client:** Use `TerminatedCloseEvent` class extending an `Error` for rejecting promises when terminating ([74b4ceb](74b4ceb)), closes [#531](#531)
* **server:** Dispose of subscriptions on close even if added late to the subscriptions list ([#534](#534)) ([e45d6b1](e45d6b1)), closes [#532](#532)

### Features

* **server:** Add is retry flag to connect events ([#507](#507)) ([9ad853f](9ad853f))
@enisdenjo
Copy link
Owner

🎉 This PR is included in version 5.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released and published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants