Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#373 Focus issues fixes #627

Merged
merged 1 commit into from Mar 20, 2024
Merged

#373 Focus issues fixes #627

merged 1 commit into from Mar 20, 2024

Conversation

DevFromDownUnder
Copy link
Contributor

Remove existing workaround

Stop windows deleting and re-adding border, which is causing focus loss as elements get dettached to the current view

#373

Remove existing workaround

Stop windows deleting and re-adding border, which was causing focus lose as elements were no longer attached to the current view
@enisn enisn self-requested a review March 19, 2024 15:05
Copy link
Owner

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, there was a bug in the border on windows and color couldn't be changed, that's why I re-created border in a windows specific code. Since this MAUI bug is resolved, this PR makes sense.

@enisn enisn merged commit d0cdeb0 into enisn:develop Mar 20, 2024
3 checks passed
@DevFromDownUnder
Copy link
Contributor Author

Thanks for your contribution, there was a bug in the border on windows and color couldn't be changed, that's why I re-created border in a windows specific code. Since this MAUI bug is resolved, this PR makes sense.

Makes sense, I was wondering what it was, figured it must have been something weird and you would test before merging

@enisn
Copy link
Owner

enisn commented Mar 21, 2024

Yes I tested before merging and works perfectly, thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants