Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global podAnnotations variable has no effect in daemonset configuration #106

Closed
dominykasn opened this issue Feb 27, 2023 · 3 comments
Closed

Global podAnnotations variable has no effect in daemonset configuration #106

dominykasn opened this issue Feb 27, 2023 · 3 comments
Assignees
@npdgm
Labels
bug Something isn't working helm released on @main released

Comments

@dominykasn
Copy link

Currently setting global podAnnotations in values.yaml file has no effect in daemonset as daemonset.yaml template seems to be taking defaults from .daemonSets

{{- with .Values.hostPathsExporter.daemonSets }}
{{- range $dsName, $dsDef := . }}

Shouldn't globally defined(-able) values be pointed to ".Values" context instead?
@npdgm npdgm self-assigned this Mar 30, 2023
@npdgm npdgm added bug Something isn't working helm labels Mar 30, 2023
npdgm added a commit that referenced this issue Apr 11, 2023
@npdgm
fix(helm): DaemonSets inherit global podAnnotations
59e1eb9 
Fixes #106
npdgm added a commit that referenced this issue Apr 11, 2023
@npdgm
fix(helm): DaemonSets inherit global podAnnotations
0ff7932 
Fixes #106
@npdgm npdgm closed this as completed in 1a670ed Apr 11, 2023
@npdgm
Copy link
Member

npdgm commented Apr 11, 2023

Thank you for reporting this, the next release will include a fix.
Cheers

@monkeynator
Copy link
Member

🎉 This issue has been resolved in version 3.7.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@monkeynator
Copy link
Member

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npdgm npdgm

Labels
bug Something isn't working helm released on @main released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@npdgm @dominykasn @monkeynator