Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: bundle dashboard with helm-chart #136

Closed
jcpunk opened this issue May 5, 2023 · 3 comments · Fixed by #150
Closed

Feature: bundle dashboard with helm-chart #136

jcpunk opened this issue May 5, 2023 · 3 comments · Fixed by #150
Assignees

Comments

@jcpunk
Copy link

jcpunk commented May 5, 2023

Kube-prometheus-stack has a pattern for including grafana dashboards with the chart.

https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/grafana/configmap-dashboards.yaml

Can the recommended dashboard be added to this chart in a similar method?

@npdgm npdgm self-assigned this May 19, 2023
@npdgm npdgm added enhancement New feature or request helm labels May 19, 2023
npdgm added a commit that referenced this issue May 22, 2023
Optional deployment of the Grafana dashboard as a ConfigMap. Requires Grafana to be deployed with sidecars and the appropriate namespace configuration.

Closes #136
npdgm added a commit that referenced this issue May 22, 2023
Optional deployment of the Grafana dashboard as a ConfigMap. Requires Grafana to be deployed with sidecars and the appropriate namespace configuration.

Closes #136
@npdgm
Copy link
Member

npdgm commented May 22, 2023

Hi @jcpunk
Thanks a lot for the suggestion, that was a great idea!
Cheers

@monkeynator
Copy link
Member

🎉 This issue has been resolved in version 3.7.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@monkeynator
Copy link
Member

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants