core/refresher: use A10=1 for an all-banks REF #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because newer DRAMs like LPDDR4 or DDR5 have separate commands for per-bank refresh and all banks refresh. Other DRAM types ignore address for REF commands.
Merged
enjoy-digital
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #224.
In LPDDR2+ and DDR5 the refresh command has two variants: per-bank and all-banks. This PR changes Refresher to always issue the all-banks variant. This should not affect other memory types, as they always refresh all banks, ignoring the address (it just must be a defined voltage level).