Flashing SPI using SFL with bios has no effect

[DurandA]

Flashing the firmware to SPI flash using litex_term --kernel firmware.fbi --flash doesn't seem to modify the flash content.

I am investigating on the issue as the fw bios command works fine.

--============== Boot ==================--
Booting from serial...
Press Q or ESC to abort boot completely.
sL5DdSMmkekro
[LXTERM] Received firmware download request from the device.
[LXTERM] Flashing firmware/firmware.fbi to 0x40000000 (8376 bytes)...
[LXTERM] Upload complete (2.6KB/s).
[LXTERM] Done.

[DurandA]

It works fine. I did not realize that erase_flash_sector() uses the 0xD8 command while the Micron N25Q128A datasheet reference this as a block...

Command	Command Code
SE (sector erase)	0x20
BE 32K (block erase 32KB)	0x52
BE (block erase 64KB)	0xD8

[mithro]

FYI -- https://github.com/litex-hub/litespi/blob/master/litespi/modules/modules.py

[mithro]

And https://github.com/litex-hub/litespi/blob/master/litespi/modules/generated_modules.py

[DurandA]

@mithro Thanks! Strangely, LiteSPI doesn't define a sector size so I wonder how partial erase is done.

[mithro]

@DurandA -- LiteSPI is only new, I logged litex-hub/litespi#35 to figure out what is happening there.