Add runtime dependency for windows instead of mentioning it in README #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sds
reviewed
Nov 18, 2020
| @@ -20,6 +20,8 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = '>= 2.4.0' | |||
|
|
|||
| s.add_runtime_dependency "ffi", "~> 1.0", ">= 1.0.11" if Gem.win_platform? | |||
There was a problem hiding this comment.
This won't do what you want. Gemspecs are evaluated at build time, so this will only work if the gem is built on a Windows machine.
We don't include the ffi gem intentionally, as the vast majority of users don't need it and it slows down installs due to the time it takes to compile native extensions.
There was a problem hiding this comment.
hmm, what about RbConfig::CONFIG['target_os'] =~ /mingw32|mswin/ then? It seems strange to require gem, but not have it in deps.
There was a problem hiding this comment.
We used to do this. Please see #160 for why we removed. There are many good reasons to not do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.