Skip to content

Commit

Permalink
Turn off a bad CI combination
Browse files Browse the repository at this point in the history
Removing another combination that consistently runs into JRuby problems.
  • Loading branch information
enkessler committed May 30, 2022
1 parent 888edfd commit 5a572fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
# ruby-version: 'jruby-9.1.17.0'

# Hits some kind of Java bug
- os: windows-latest
ruby-version: jruby-9.3.4.0
gemfile: gherkin22
- os: windows-latest
ruby-version: jruby-9.3.4.0
gemfile: gherkin20
Expand Down
4 changes: 0 additions & 4 deletions testing/gemfiles/gherkin22.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,5 @@ else
end
# rubocop:enable Bundler/DuplicatedGem

# JRuby + Windows
if (RUBY_PLATFORM == 'java') && (RbConfig::CONFIG['host_os'] =~ /mingw32|mswin32/)
gem 'jruby-win32ole' # Some versions of Cucumber rely on this and it seems to not be automatically included
end

gem 'cucumber-gherkin', '~> 22.0'

0 comments on commit 5a572fe

Please sign in to comment.