-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query parameters not passed to form resources #1041
Comments
Thanks for filing this @MartijnR. I believe I've found the cause: in enketo/enketo-transformer#111, when provided an absolute/relative URL, only the path is returned. This is obviously incorrect, thankfully it should be a trivial fix. |
Oh that's great. Thanks! |
@eyelidlessness Is this just an issue with Aggregate or does it affect Central? And if it does, what types of forms does it affect? I guess what I'm asking is that should we plan a hot fix for Central? |
@yanokwa It affects anything that uses query parameters in media mappings. I haven't seen that in Central but I don't know whether that's possible. |
@lognaturel Says it's not an issue for Central (whew!). @MartijnR how urgently do you need this released? |
Not urgent! Thanks for checking. |
Fixed by enketo/enketo-transformer#132 |
Describe the bug
It looks like any form with media hosted on Aggregate is failing to load those media files. For a form with images this fails silently. For a form with external data this fails with an "Unable to auto-detect delimiting character; defaulted to ','" error.
To Reproduce
curl --user enketorules: -d "server_url=https://enketo-aggregate.appspot.com&form_id=widgets_on_pages" http://localhost:8005/api/v2/survey/
Expected behavior
Form to load with media resources.
Additional context
Link to media manifest on Aggregate for this form: https://enketo-aggregate.appspot.com/xformsManifest?formId=widgets_on_pages
I looks like a link to a download url such as https://enketo-aggregate.appspot.com/xformsDownload?blobKey=aggregate.opendatakit.org%3AFormInfo%5B%40version%3D1+and+%40uiVersion%3D0%5D%2F_form_info%5B%40key%3Dmd5%3Acc0a52104c3e1028d7b23cca46837e72%5D%2F_form_info_fileset%5B%40ordinal%3D1%5D%2FmanifestFileset%5B%40ordinal%3D1%5D&as_attachment=true no longer survives into the transformation result.
I believe the whole query part of the download URL is stripped out.
A simpler form without external data:
curl --user enketorules: -d "server_url=https://enketo-aggregate.appspot.com&form_id=big-image" http://localhost:8005/api/v2/survey
The regression occurred in 3.0.2
The text was updated successfully, but these errors were encountered: