This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: ensure form_logo.png is included when present in media mapping #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes enketo/enketo#81.
I have verified this PR works with
What else has been done to verify that this works as intended?
Tests for both presence of form_logo.png and escaping its base path.
Why is this the best possible solution? Were any other approaches considered?
This was a regression in enketo/enketo#401, which incorrectly restored the original escaping logic that was removed in enketo/enketo#477. That logic previously mutated the
surveyparameter, when restoring it I intended to return a newsurveyobject but missed this particular one.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I can not foresee any risk from this change that wasn't already a risk in enketo/enketo#401 or enketo/enketo#477.
Do we need any specific form for testing your changes? If so, please attach one.
See the attachment on enketo/enketo#81.