This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Npmjs release process #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyelidlessness
suggested changes
Oct 19, 2021
There was a problem hiding this comment.
I agree it's good to move from Travis to GitHub Actions, at least in theory. It's not immediately clear to me why this didn't run the Action, but I suspect it's because the PR is opened from a fork. I think we may need to change something in settings (which I can't access, so I'm not sure), or relax the branches filters somehow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's nice to have a single place to run the tests and deploys, so I've removed Travis.
I've also documented the process I've used in the past.
I commented out the tests that we know are broken so publishing works. If there is a better and more visible (e.g., we won't forget that we've done this) way do this, let me know.