Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit from Login dialog #139

Closed
ZedZipDev opened this issue Jan 21, 2020 · 6 comments
Closed

Exit from Login dialog #139

ZedZipDev opened this issue Jan 21, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed suggestion Consider addid this

Comments

@ZedZipDev
Copy link

I am here https://blazorboilerplate.com/todo_list , then click Login, but do not want to Log in and want to exit and return to the todo_list page. But in the Login dialog is only button "Home". I think it may be good to close dialog and return to the previous page but not to Home always.

@enkodellc enkodellc added help wanted Extra attention is needed suggestion Consider addid this enhancement New feature or request labels Jan 21, 2020
@enkodellc
Copy link
Owner

@Oleg26Dev thanks, I agree. This sounds like a good first PR for someone.

@soomon
Copy link
Contributor

soomon commented Jan 21, 2020

Why not use the back button of your browser?

@ZedZipDev
Copy link
Author

ZedZipDev commented Jan 22, 2020

@soomon It can be quick solution but I think as a user. Login looks like modal dialog and have a button "Home". I'd like to exit, I click Home because no other buttons.
May be button "<-" instead of Home. Keith knows better ;-)

@enkodellc
Copy link
Owner

I agree that a return arrow to return to the previous page. is a good idea. I don't know if there is any mechanism like asp.net's urlreferrer within Blazor. I am swamped with answering questions and other maintenance with BB. I wish to gain more contributors so this should be a fairly simple task for someone's first PR! @Oleg26Dev maybe you want to do some research and find if a solution is out there for this feature. Another option might be to create a modal Dialog for Login instead of a page. Then exiting the login will just close the dialog and no need for a urlreferrer needed.

@win32nipuh
Copy link

@enkodellc ok, I will check what can be done (as I see it ;-))

@enkodellc
Copy link
Owner

@win32nipuh, Great! One of the goal's of BB, maybe not spelled out is to get new contributors involved in features and solutions. It is definitely not for devs to make suggestions to me and and I solve if for them :)

ZedZipDev pushed a commit to ZedZipDev/blazorboilerplate that referenced this issue Feb 2, 2020
enkodellc added a commit that referenced this issue Feb 6, 2020
Fixed: Exit from Login dialog #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed suggestion Consider addid this
Projects
None yet
Development

No branches or pull requests

4 participants