invalid method calls to method where

[jasperf]

We have a Laravel command based on Clarkeash Doorman's Invitation package and Enlightn mentioned that line 41 Invite::where('valid_until', '<', now()) has an invalid method call to method(s): Your application seems to contain invalid method calls to methods that either do not exist or do not match the method signature or scope.

Here our command code:

<?php

namespace App\Console\Commands;

use Clarkeash\Doorman\Models\Invite;
use Illuminate\Console\Command;

class InviteClean extends Command
{
   /**
    * The name and signature of the console command.
    *
    * @var string
    */
   protected $signature = 'invite:clean';

   /**
    * The console command description.
    *
    * @var string
    */
   protected $description = 'Remove invites that were expired';

   /**
    * Create a new command instance.
    *
    * @return void
    */
   public function __construct()
   {
       parent::__construct();
   }

   /**
    * Execute the console command.
    *
    * @return mixed
    */
   public function handle()
   {
       Invite::where('valid_until', '<', now())
               ->where('uses', 0)
               ->delete();
   }
}

I fail to understand the issue here. Would someone please explain what I am missing here?

[paras-malhotra]

@jasperf can you run this with the --details flag? Model::where looks perfectly fine and shouldn't be detected as an error.

[jasperf]

Did just update to latest Enlightn and ran with --details flag just now and see

check 30/61: Your application does not contain invalid method calls. Failed
Your application seems to contain invalid method calls to methods that either do not exist or do not match the method signature or scope.
At /app/Console/Commands/InviteClean.php, line 41: Static call to instance method Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::where().

[paras-malhotra]

Hi @jasperf, the issue is with the @mixin docblock annotation here. Here's a related issue.

I would suggest that it's best for you to ignore this error using the ignore_errors config option. Docs here.

[paras-malhotra]

@jasperf the path would be app/Console/Commands/InviteClean.php. You can even auto-generate these by running the enlightn:baseline Artisan command to ignore all current errors if you want. Here's the docs link for the baseline command.

[jasperf]

Thanks for that @paras-malhotra . Read at phpDocumentor/fig-standards#35 some more about the usage of @mixin to make the IDE (PHP Storm mainly?) load/recognize certain classes the IDE has issues with so you can see reference more properly. But now it seems Enlightn / PHPStan can't work properly with @mixin Builder set up so we need to exclude the while file from checks.

I would think a PHPStan fix like by adding this to phpstan.neon:

parameters:
    mixinExcludeClasses:
        - Illuminate\Database\Eloquent\Builder

See PHPStan docs

as shown at larastan/larastan#588 would be better then.. Or at least one line per @mixin reference perhaps. I mean, you would not need to exclude all the files that benefit from using @mixin.. or am I seeing this wrong here?

[jasperf]

Come to think of it.. would be better if we could somehow just ignore @mixin and still have the option to check files that refer to files that use... @mixin.

In my App Larastan (perhaps to work with mixins in Larastan and in other apps just to use the mixins) many files have @mixin:

...
./vendor/clarkeash/doorman/src/Models/BaseInvite.php: * @mixin Builder
./vendor/nunomaduro/larastan/stubs/Redis/Connection.stub: * @mixin \Redis
./vendor/nunomaduro/larastan/stubs/Contracts/Pagination.stub: * @mixin \Illuminate\Support\Collection
./vendor/nunomaduro/larastan/stubs/Contracts/Pagination.stub: * @mixin \Illuminate\Pagination\Paginator
./vendor/nunomaduro/larastan/stubs/Contracts/Pagination.stub: * @mixin \Illuminate\Support\Collection
./vendor/nunomaduro/larastan/stubs/Contracts/Pagination.stub: * @mixin \Illuminate\Pagination\LengthAwarePaginator
./vendor/nunomaduro/larastan/stubs/Logger.stub:     * @mixin \Illuminate\Log\LogManager
./vendor/nunomaduro/larastan/stubs/Logger.stub:     * @mixin \Monolog\Logger
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Redis
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Redis\RedisManager
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Contracts\Redis\Factory
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Database\DatabaseManager
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Database\Connection
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Database\ConnectionInterface
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Queue\QueueManager
./vendor/nunomaduro/larastan/stubs/Facades.stub: * @mixin \Illuminate\Queue\Queue
./vendor/nunomaduro/larastan/stubs/JsonResource.stub: * @mixin TModelClass
./vendor/nunomaduro/larastan/stubs/Pagination.stub: * @mixin \Illuminate\Support\Collection
Binary file ./vendor/bin/phpstan.phar matches
./vendor/ctf0/media-manager/src/resources/assets/sass/partials/vars.scss:@mixin media($amount, $point) {
./vendor/webmozart/assert/CHANGELOG.md:This interface is linked to the `Assert` class with a `@mixin` annotation. Most IDE's have supported this
./vendor/webmozart/assert/src/Assert.php: * @mixin Mixin
./vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php: * @mixin \Illuminate\Database\Connection
....
./vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php: * @mixin \Illuminate\Contracts\Filesystem\Filesystem
./vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php: * @mixin \League\Flysystem\FilesystemInterface
./vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php: * @mixin \Illuminate\Http\Response
./vendor/laravel/framework/src/Illuminate/Support/ViewErrorBag.php: * @mixin \Illuminate\Contracts\Support\MessageBag
./vendor/laravel/framework/src/Illuminate/Queue/Capsule/Manager.php: * @mixin \Illuminate\Queue\QueueManager
./vendor/laravel/framework/src/Illuminate/Queue/Capsule/Manager.php: * @mixin \Illuminate\Contracts\Queue\Queue
./vendor/laravel/framework/src/Illuminate/Queue/QueueManager.php: * @mixin \Illuminate\Contracts\Queue\Queue
./vendor/laravel/framework/src/Illuminate/Routing/Router.php: * @mixin \Illuminate\Routing\RouteRegistrar
./vendor/laravel/framework/src/Illuminate/Collections/HigherOrderCollectionProxy.php: * @mixin \Illuminate\Support\Enumerable
./vendor/laravel/framework/src/Illuminate/Collections/HigherOrderWhenProxy.php: * @mixin \Illuminate\Support\Enumerable
..

See laravel/framework#20229

[jasperf]

Well as it seems mainly Illuminate classes have this @mixin only and few others I will try to use

'ignore_errors' => [
    \Enlightn\Enlightn\Reliability\InvalidMethodCallAnalyzer::class => [
        [
            'path' => 'app/Console/Commands/InviteClean.php',
            'details' => '*Static call to instance method*',
        ],
    ],
]

but still saw Your application seems to contain invalid method calls to methods that either do not exist or do not match the method signature or scope. At /app/Console/Commands/InviteClean.php, line 41: Static call to instance method Illuminate\Database\Eloquent\Builder<Illuminate\Database\Eloquent\Model>::where().

Update: had to php artisan config:clear My bad.

[paras-malhotra]

Hi @jasperf, try auto-generating the ignore_errors using php artisan enlightn:baseline. You can copy the ignore_errors entry from there I think.