chore(dev-deps): upgrade dev deps to newer versions #61
Conversation
|
@snapshotpl mind taking a look at this one? i have just one more pull request planned before requesting another commit from you to bump Monolog and PHP : ))) |
.travis.yml
Outdated
| @@ -26,20 +23,6 @@ jobs: | |||
| allow_failures: | |||
| - php: 7.4snapshot | |||
.travis.yml
Outdated
| @@ -3,13 +3,10 @@ language: php | |||
| dist: trusty | |||
There was a problem hiding this comment.
It's good time to update distro to bionic https://docs.travis-ci.com/user/reference/bionic/#php-support
| "jakub-onderka/php-parallel-lint": "^0.9", | ||
| "johnkary/phpunit-speedtrap": "^1.0", | ||
| "squizlabs/php_codesniffer": "^2.9", | ||
| "phpunit/phpunit": "^5|^4.8" |
There was a problem hiding this comment.
i believe phpunit 8 requires php72. i figured we can do that in a subsequent pull where you bump monolog. what do you think?
There was a problem hiding this comment.
It isn't problem. You can keep also 7.5 and prepare to smooth switch in future
There was a problem hiding this comment.
@snapshotpl here's the most recent php74 master build using latest deps:
https://travis-ci.org/enlitepro/enlite-monolog/jobs/632741435?utm_medium=notification&utm_source=github_status
php8 now throws several deprecation notices, which i see you've addressed in #57
i was hoping you'd be interested in addressing those deprecations in a separate PR, so that we can clean up 2.x before we cut 3.0 : )
|
@snapshotpl happy new year! your reviews are awesome : ) |
abacaphiliac
force-pushed
the
upgrade-dev-deps
branch
from
8e81760
to
618e7f3
Compare
chore(dev-deps): upgrade integration test app dev deps
abacaphiliac
force-pushed
the
upgrade-dev-deps
branch
from
618e7f3
to
949a050
Compare
|
@snapshotpl please take another look when you have some time. thanks! |
|
@abacaphiliac looks fine now! |
related to #57
monolog:^2requiresphp:^7.2, which means very soon we will not be able to build this project on older versions of PHP. this is a small step in that direction, where we're upgrading PHPUnit (and friends) to newer versions which likewise no longer support the oldest versions of PHP.changes like this (bumping dependency requirements with no change to the public API) can be released as 2.x because Composer will resolve pre-existing versions of this package for systems that use older versions of PHP.