Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS12 branch is unusable due to Swift4.2-incompatbile PMAlertController #121

Closed
robbiet480 opened this issue Sep 21, 2018 · 12 comments
Closed

Comments

@robbiet480
Copy link
Contributor

robbiet480 commented Sep 21, 2018

Currently, PMAlertController is spewing a lot of errors during build on a Swift4.2 project due to Swift 4.2 changes. I've gotten around this by doing the following:

  1. Removing the version requirement of the s.dependency in the Podspec
  2. Installing PMAlertController via a fork which has been updated for Swift4.2
  3. Configuring my Podfile like this so that arek has access to PMAlertController:
pod 'PMAlertController', :git => 'https://github.com/gorbat-o/PMAlertController.git', :branch => 'swift4.2'
pod 'arek', :git => 'https://github.com/robbiet480/arek.git', :branch => 'iOS12'
@gorbat-o
Copy link

gorbat-o commented Sep 21, 2018

Hey, the pull request is created on PMAlertController :)
pmusolino/PMAlertController#71

Edit: PMA is updated :)

@ennioma
Copy link
Owner

ennioma commented Sep 25, 2018

Fixed, going to release it ;)

@ennioma ennioma closed this as completed Sep 25, 2018
@ennioma
Copy link
Owner

ennioma commented Sep 25, 2018

@robbiet480, @gorbat-o please when you have time could you please check the release 4.0.0?

@gorbat-o
Copy link

Hey @ennioma

So, I tried to remove the branch iOS12 from the podfile and it does not compile cause it is not catching the 4.0.0 version with a pod update
and if I am specifying the version like this pod 'arek/Camera', '4.0.0' it says

[!] CocoaPods could not find compatible versions for pod "arek/Camera":
  In Podfile:
    arek/Camera (= 4.0.0)

None of your spec sources contain a spec satisfying the dependency: `arek/Camera (= 4.0.0)`.

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by default.

@ennioma
Copy link
Owner

ennioma commented Sep 26, 2018

I forgot to submit the pod to Cocopods 🤦🏻‍♂️

@gorbat-o
Copy link

@ennioma hey
did you submit it ?
I still have the error :/

@ennioma
Copy link
Owner

ennioma commented Sep 26, 2018

Yes! @gorbat-o try the version 4.0.1 please

@ennioma ennioma reopened this Sep 26, 2018
@gorbat-o
Copy link

gorbat-o commented Sep 26, 2018

I might do something wrong I guess.. :/
Still not working :/

[!] CocoaPods could not find compatible versions for pod "arek/Contacts":
  In Podfile:
    arek/Contacts (= 4.0.1)

Specs satisfying the `arek/Contacts (= 4.0.1)` dependency were found, but they required a higher minimum deployment target.

Is the minimum deployment target changed ? :/

EDIT: I changed my minimum deployment target to ios11 and it works 👍
Too bad for people under ios10 😂

@ennioma
Copy link
Owner

ennioma commented Sep 27, 2018

Life is going fast ahead :P

@ennioma ennioma closed this as completed Sep 27, 2018
@robbiet480
Copy link
Contributor Author

@ennioma Was there a specific reason to set the deployment target to iOS 11? Most apps with large user bases support the last 2 major iOS versions. I'm gonna need to hack around with the Podspec to get this installed with a deployment target of iOS 10. It doesn't appear like there's anything that required the switch to 11 but I'm probably missing something.

@ennioma
Copy link
Owner

ennioma commented Oct 2, 2018

Hey @robbiet480 I've created the PR #127 only for the releases that will support Xcode 10. Let me know what you think

@ennioma
Copy link
Owner

ennioma commented Oct 2, 2018


🎉 Congrats

🚀 arek (4.0.2) successfully published
📅 October 2nd, 23:07
🌎 https://cocoapods.org/pods/arek
👍 Tell your friends!

And the release is here 🤙🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants