Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ghc-8.10.1 #45

Merged
merged 1 commit into from
May 16, 2020
Merged

Support for ghc-8.10.1 #45

merged 1 commit into from
May 16, 2020

Conversation

jneira
Copy link
Contributor

@jneira jneira commented May 13, 2020

  • Simply relaxing upper bounds of base and ghc-prim.
    • It compiles with cabal build -w ghc-8.10.1
    • i've run the test suite in my windows 10 and it fails like master with ghc-8.8.3 so i cant use it as check.
  • Needed for haskell-ide-engine and haskell-language-server
  • Maybe a hackage revision would be enough to add the support, as there is no code changes

@ennocramer
Copy link
Owner

Awesome! Thank you! I'll publish a hackage revision as well.

@ennocramer ennocramer merged commit d15f3b9 into ennocramer:master May 16, 2020
@jneira
Copy link
Contributor Author

jneira commented May 17, 2020

@ennocramer thanks a lot! I've tried to use the hackage revision in hls and i am afraid that it fails due to the bound over haskell-src-exts <1.23. It was changed with 6116f7 and it needed some code changes so it will need a release.

@ennocramer
Copy link
Owner

Sorry, I should have realized we need a proper release and not just a hackage revision. I published floskell-0.10.3 just now.

@jneira
Copy link
Contributor Author

jneira commented May 17, 2020

No problem, i did not mention haskell-src-exts neither.
I've already used the new version: haskell/haskell-language-server#116
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants