Support aeson >= 2.0 #69
Conversation
| #if MIN_VERSION_aeson(2,0,0) | ||
| import qualified Data.Aeson.KeyMap as Map | ||
| #else | ||
| import qualified Data.Aeson.Parser as JSON ( json' ) |
There was a problem hiding this comment.
i am preserving this import although the compiler warns it is unused, maybe it was not reexported in some aeson version?
There was a problem hiding this comment.
I think that's from a bad merge between this PR and #70. The current status of the file shows Data.Aeson.KeyMap being imported twice: once as JSON (#70) and once as Map (#69). Also it looks like this PR erased the CPP in mine at the use site, so I'd expect there to be errors now for anyone trying to use aeson<2.0
There was a problem hiding this comment.
The CPP at the use site is not necessary, as both Data.HashMap.Lazy and Data.Aeson.KeyMap are imported as Map now, so the call is Map.unionWith either way.
I'll merge @jneira 's followup PR now but will leave the Hackage release unchanged.
|
Very nice, thank you! |
|
@ennocramer thank you for the fast response, could we get a hackage release with this change included? it would include support for ghc-9.0.1 (#66) and we could include the floskell plugin in hls when installing from hackage |
|
I’ll do a hackage release later today. I ran into an issue building the benchmarks with GHC-9.2.1 and want to see if I can fix that before releasing. |
Thanks in advance @ennocramer