Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install App Dialog - error message still shown after correct application URL was submitted #89

Closed
sgauruseu opened this issue May 9, 2019 · 0 comments
Closed

Install App Dialog - error message still shown after correct application URL was submitted #89

sgauruseu opened this issue May 9, 2019 · 0 comments
Assignees
@ashklianko
Labels
Bug Something isn't working

Comments

@sgauruseu
Copy link
Member

sgauruseu commented May 9, 2019 •
edited by alansemenov

  1. Open Install Dialog and paste in this URL into the field:
    http://repo.enonic.com/public/com/enonic/app/contentviewer/1.4.0/contentviewer-1.4.0.jar

  2. Press Enter

Validation message appears (OK):
step1

  1. Correct the URL to https://

  2. Press Enter

Bug: URL is correct and the application is being installed but validation message is still displayed
image

We should also disable the field and the upload button while the application is being installed via URL.
@sgauruseu sgauruseu added the Bug Something isn't working label May 9, 2019
@alansemenov alansemenov changed the title Install App Dialog - validation message after the URL has been corrected Install App Dialog - hide validation message after URL has been resubmitted May 9, 2019
@ashklianko ashklianko self-assigned this May 13, 2019
ashklianko added a commit that referenced this issue May 14, 2019
@ashklianko
Install App Dialog - hide validation message after URL has been resub…
c8276c5 
…mitted #89

-Tons of refactoring
@ashklianko ashklianko mentioned this issue May 14, 2019
Closed
ashklianko added a commit that referenced this issue May 27, 2019
@ashklianko
Install App Dialog - hide validation message after URL has been resub…
05d55ec 
…mitted #89

-Tons of refactoring
@ashklianko ashklianko mentioned this issue May 27, 2019
Merged
@alansemenov alansemenov changed the title Install App Dialog - hide validation message after URL has been resubmitted Install App Dialog - error message still shown after correct application URL was submitted May 29, 2019
alansemenov pushed a commit that referenced this issue May 29, 2019
@ashklianko @alansemenov
Install App Dialog - hide validation message after URL has been resub…
dad957e 
…mitted #89

-Tons of refactoring

(cherry picked from commit 05d55ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgauruseu @ashklianko @alansemenov