Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content form is auto-collapsed when a component is selected in PCV #7159

Closed
alansemenov opened this issue Dec 7, 2023 · 0 comments · Fixed by #7161
Closed

Content form is auto-collapsed when a component is selected in PCV #7159

alansemenov opened this issue Dec 7, 2023 · 0 comments · Fixed by #7161
Assignees
@ashklianko
Labels
Bug Something isn't working

Comments

@alansemenov
Copy link
Member

We should distinguish between when a component is selected in the Page Editor and inlined PCV. When working with the Page Editor, it's logical to collapse the form to give more room to the Editor. But when user works inside the form (selects a component inside the PCV) we should not auto-collapse it.
@alansemenov alansemenov added the Bug Something isn't working label Dec 7, 2023
ashklianko added a commit that referenced this issue Dec 7, 2023
@ashklianko
Content form is auto-collapsed when a component is selected in PCV #7159
900e0e0 


- Tracking source of the select/inspect event, so if it is triggered from Live Edit then don't collapse
@ashklianko ashklianko linked a pull request Dec 7, 2023 that will close this issue
Content form is auto-collapsed when a component is selected in PCV #7159 #7161
Merged
ashklianko added a commit that referenced this issue Dec 7, 2023
@ashklianko
Content form is auto-collapsed when a component is selected in PCV #7159
afdc065 


- Tracking source of the select/inspect event, so if it is triggered from Live Edit then don't collapse
alansemenov pushed a commit that referenced this issue Dec 8, 2023
@ashklianko @alansemenov
Content form is auto-collapsed when a component is selected in PCV #7159
f344159 


- Tracking source of the select/inspect event, so if it is triggered from Live Edit then don't collapse
alansemenov pushed a commit that referenced this issue Dec 8, 2023
@ashklianko @alansemenov
Content form is auto-collapsed when a component is selected in PCV #7159
72e3009 


- Tracking source of the select/inspect event, so if it is triggered from Live Edit then don't collapse
@alansemenov alansemenov mentioned this issue Dec 8, 2023
Open
ashklianko added a commit that referenced this issue Dec 22, 2023
@ashklianko
Content form is auto-collapsed when a component is selected in PCV #7159
156fc76 


- Tracking source of the select/inspect event, so if it is triggered from Live Edit then don't collapse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Content form is auto-collapsed when a component is selected in PCV #7159 enonic/app-contentstudio
2 participants
@ashklianko @alansemenov