Set gradle parameter with environmental variables #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you control. gradlew? It is automatically generated by Gradle and comes from the projects, not CLI. |
I should have said, changed how we called it :) The automatically generated script looks at the |
|
Awesome! |
|
We'll need to release a new version asap then... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
./gradlewscript uses the env variable$JAVA_HOMEto set the java binary location, not the-Dorg.gradle.java.homeparameter, I changed how we called it.Now it uses the env variables for
JAVA_HOMEandXP_HOME. This fixes the issue on Linux when the Snap complained about an invalid$JAVA_HOME. Now when runningenonic project deployit uses the distribution rather than Java installed on the machine.This has been tested on Linux (running bash) and it worked. I have not tested this on Window, Cygwin (Windows) or Mac (Although it should work for bash on macs aswell).