Skip to content

Commit

Permalink
Edit Permissions Dialog shows incorrect content name #4752
Browse files Browse the repository at this point in the history
-also fixed ui tests
  • Loading branch information
ashklianko committed Apr 5, 2017
1 parent 457c2dc commit e413c3a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,8 @@ export class ContentWizardPanel extends api.app.wizard.WizardPanel<Content> {

if (content.getType().isImage()) {
this.updateWizard(content);
} else if (this.isSecurityWizardStepFormAllowed) { // update security wizard to have new path/displayName etc.
this.securityWizardStepForm.update(content);
}

return content;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,32 @@ describe('api.security.Principal', () => {

it('given an equal then true is returned', () => {

let principal1 = Principal.create().setKey(PrincipalKey.ofAnonymous()).setDisplayName('Anon').setModifiedTime(now).build();
let principal2 = Principal.create().setKey(PrincipalKey.ofAnonymous()).setDisplayName('Anon').setModifiedTime(now).build();
let principal1: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(
PrincipalKey.ofAnonymous()).setDisplayName('Anon').build();
let principal2: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(
PrincipalKey.ofAnonymous()).setDisplayName('Anon').build();

expect(principal1.equals(principal2)).toBeTruthy();
});

it('given unequal displayName then false is returned', () => {

let principal1 = Principal.create().setKey(PrincipalKey.ofAnonymous()).setDisplayName('Anon').setModifiedTime(now).build();
let principal2 = Principal.create().setKey(PrincipalKey.ofAnonymous()).setDisplayName('Other').setModifiedTime(now).build();
let principal1: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(
PrincipalKey.ofAnonymous()).setDisplayName('Anon').build();
let principal2: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(
PrincipalKey.ofAnonymous()).setDisplayName('Other').build();

expect(principal1.equals(principal2)).toBeFalsy();
});

it('given unequal type then false is returned', () => {

let principal1 = Principal.create().setKey(PrincipalKey.fromString('user:mystore:other')).setDisplayName(
'Anon').setModifiedTime(now).build();
let principal2 = Principal.create().setKey(PrincipalKey.fromString('user:mystore:other')).setDisplayName(
'Anon').setModifiedTime(later).build();
let principal1: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(
PrincipalKey.fromString('user:mystore:other')).setDisplayName(
'Anon').build();
let principal2: Principal = <Principal>Principal.create().setModifiedTime(later).setKey(
PrincipalKey.fromString('user:mystore:other')).setDisplayName(
'Anon').build();

expect(principal1.equals(principal2)).toBeFalsy();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ describe('api.security.acl.AccessControlEntry', () => {

describe('equals', () => {

let principal1 = Principal.create().setKey(PrincipalKey.ofAnonymous()).setDisplayName('principal1').setModifiedTime(now).build();
let principal1: Principal = <Principal>Principal.create().setModifiedTime(now).setKey(PrincipalKey.ofAnonymous()).setDisplayName(
'principal1').build();

it('given an equal then true is returned', () => {

Expand Down

0 comments on commit e413c3a

Please sign in to comment.