Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outline and tab order of items in the toolbar #4492

Closed
alansemenov opened this issue Feb 28, 2017 · 0 comments
Closed

Fix outline and tab order of items in the toolbar #4492

alansemenov opened this issue Feb 28, 2017 · 0 comments
Assignees
Milestone

Comments

@alansemenov
Copy link
Member

  1. HomeButton should not be clickable in Content Studio and Applications (keep it in the Users app since there we still have wizard tabs).

  2. When the app's main page opens, the Launcher button must be focused and have visible outline:
    image

  3. Tabbing out of the Launcher button must follow logical order of elements. For example, in the Content Studio focus should go from the launcher button to search icon, then New action button etc. It seems to work in Chrome, but in Firefox outline is not visible. It seems that the only element that is visibly outlined in Firefox is the Publish button in the grid toolbar.

  4. NonMobileDetailsPanelToggleButton never gets a focus. It must be focused after the Publish button or - if it's disabled - right after the last action button in the toolbar.

  5. In the Content Wizard when I Shift-tab from display name, then to the content icon, and the Publish button gets focus. This is wrong - there are toggle buttons to the right of the Publish button which must get focus in correct order (if they are visible and enabled, of course).

@alansemenov alansemenov added this to the Sprint 194 milestone Feb 28, 2017
@edloidas edloidas self-assigned this Feb 28, 2017
edloidas added a commit that referenced this issue Mar 1, 2017
Disabled HomeButton for all apps, except User Manager.
edloidas added a commit that referenced this issue Mar 1, 2017
Added autofocus to launcher button on app rendered.
Updated launcher button padding.
edloidas added a commit that referenced this issue Mar 1, 2017
Updated outline on focused elements if Firefox to look it same, as in Chrome.
edloidas added a commit that referenced this issue Mar 1, 2017
Updated `NonMobileDetailsPanelToggleButton` to inherit from `button``, instead of `div`
edloidas added a commit that referenced this issue Mar 1, 2017
Updated `ContentBrowseToolbar` to use flexbox, instead of float to fix the focus order for `ContentPublishMenuButton`.
edloidas added a commit that referenced this issue Mar 1, 2017
Updated `ContentWizardToolbar` to use flexbox, instead of float to fix the focus order.
edloidas added a commit that referenced this issue Mar 1, 2017
Updated `ContentWizardToolbar` to use flexbox, instead of float to fix the focus order.
alansemenov added a commit that referenced this issue Mar 2, 2017
Fix outline and tab order of items in the toolbar #4492
@srs srs removed this from the Sprint 194 milestone Mar 7, 2017
@srs srs closed this as completed Mar 14, 2017
@alansemenov alansemenov added this to the 6.10.0 milestone Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants