Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch content selector to default tree-structure #4933

Closed
alansemenov opened this issue May 12, 2017 · 3 comments
Closed

Switch content selector to default tree-structure #4933

alansemenov opened this issue May 12, 2017 · 3 comments
Assignees
Labels

Comments

@alansemenov
Copy link
Member

alansemenov commented May 12, 2017

Everybody loves tree-structure inside content selector in the Move dialog, so we should make this default behaviour.

NB! Since content selector can have different kinds of filtering applied to it (allowPath, allowContentType), we should make sure that we always show nodes that have children, but don't let them be selected (don't render checkbox for multi-select and don't handle the click for single-select) if they are not allowed by filters. Nodes that don't have children and are not allowed by filters should not be shown in the tree.

To enable having current "flat" structure, implement support of a config option flat:

<input name="name" type="ContentSelector">
  <label>Cited In</label>
  <occurrences minimum="0" maximum="0"/>
  <config>
      <flat>true</flat>
  </config>
</input>
@Bellfalasch
Copy link
Contributor

+1 for also adding this to Image Selector, equally important to have it there too. It's almost hopeless to text-search in 1000+ item archives of images and content.

@alansemenov alansemenov changed the title Switch content selector to tree-structure multi-select Switch content selector to default tree-structure May 12, 2017
@alansemenov
Copy link
Member Author

@Bellfalasch It's a bit more complicated for image selector since there we should make sure that parent nodes are not selectable and add deep filtering of nodes that don't have any image content. But we'll get there.

@Bellfalasch
Copy link
Contributor

Doh, worth a shot =) At least having it added to ContentSelector is good progress. As you saw on meetup, both of these are highly requested by users. @alansemenov

vbradnitski added a commit that referenced this issue Jun 29, 2017
vbradnitski added a commit that referenced this issue Jun 29, 2017
alansemenov added a commit that referenced this issue Jun 29, 2017
vbradnitski added a commit that referenced this issue Jun 30, 2017
vbradnitski added a commit that referenced this issue Jun 30, 2017
@jsi jsi closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants