Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node lib - Push - IncludeChildren is ignored #7100

Closed
jsi opened this issue May 2, 2019 · 3 comments
Closed

Node lib - Push - IncludeChildren is ignored #7100

jsi opened this issue May 2, 2019 · 3 comments
Assignees
@vbradnitski
Labels
Bug
Milestone
7.1.0

Comments

@jsi
Copy link
Member

jsi commented May 2, 2019 •
edited

Testing out with app-features, I have created a parent and a child, then try to modify them. The diff status is NEW for the child, untill I push it separately.

This is for 7.0.0-RC3
@jsi jsi added the Bug label May 2, 2019
@jsi
Copy link
Member Author

jsi commented May 2, 2019

Just noticed a strange thing: In PushNodeHandler.java , includeChildren appears to be default true. Is this inteded?

@jsi jsi changed the title Can't get includeChildren to work for lib-node push. Can't get includeChildren to work for lib-node push. May 3, 2019
@alansemenov
Copy link
Member

@GlennRicaud is this a 7.0 fix?

@GlennRicaud
Copy link
Contributor

GlennRicaud commented Aug 16, 2019 •
edited

  • PushNodeHandler default values are ignored -> To clean

  • PushNodeHandlerParams default values are always overwritten and are the exact opposite of the values in the JS code -> To clean

  • Try to reproduce the problem of Jsi and fix if reproduced.

vbradnitski added a commit that referenced this issue Aug 21, 2019
@vbradnitski
Can't get includeChildren to work for lib-node push. #7100
e6aee7c
vbradnitski added a commit that referenced this issue Aug 21, 2019
@vbradnitski
Can't get includeChildren to work for lib-node push. #7100
9a52dea 
unused default params values removed.
vbradnitski added a commit that referenced this issue Aug 21, 2019
@vbradnitski
Can't get includeChildren to work for lib-node push. #7100
4e6f7d0
GlennRicaud added a commit that referenced this issue Aug 29, 2019
@GlennRicaud
Merge pull request #7311 from enonic/issue-7100
4a4bbc1 
Can't get includeChildren to work for lib-node push. #7100
@GlennRicaud GlennRicaud changed the title Can't get includeChildren to work for lib-node push. Node lib - Push - IncludeChildren is ignored Aug 29, 2019
@GlennRicaud GlennRicaud added this to the 7.1.0 milestone Aug 29, 2019
@rymsha rymsha mentioned this issue Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbradnitski vbradnitski

Labels
Bug
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
4 participants
@jsi @vbradnitski @alansemenov @GlennRicaud