-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Names are still present in admin interface #7634
Labels
Comments
alansemenov
changed the title
Component Names
Component Names are still present in admin interface
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component names do not seem to be mapped back to JS anymore but they seem to still be returned in the Admin rest interface or when generating a fragment
-> Investigate what are the users of component names
The main problem is how this field is populated.
In the case of image or fragment components, a call to "contentService.getById" is done for each of these components, just to get the display name of the related content and set it as a name on the component.
-> Fix at least this behaviour. Investigate the impact of a change of value for component names
IMO, if there needs to be some additional retrievals just for admin, they should be done at admin level and definitely not in the node->content translation
The text was updated successfully, but these errors were encountered: