Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Names are still present in admin interface #7634

Closed
GlennRicaud opened this issue Nov 12, 2019 · 0 comments
Closed

Component Names are still present in admin interface #7634

GlennRicaud opened this issue Nov 12, 2019 · 0 comments
Assignees
Labels

Comments

@GlennRicaud
Copy link
Contributor

GlennRicaud commented Nov 12, 2019

Component names do not seem to be mapped back to JS anymore but they seem to still be returned in the Admin rest interface or when generating a fragment
-> Investigate what are the users of component names

The main problem is how this field is populated.
In the case of image or fragment components, a call to "contentService.getById" is done for each of these components, just to get the display name of the related content and set it as a name on the component.
-> Fix at least this behaviour. Investigate the impact of a change of value for component names

IMO, if there needs to be some additional retrievals just for admin, they should be done at admin level and definitely not in the node->content translation

@GlennRicaud GlennRicaud added this to the 7.2.0 milestone Nov 12, 2019
@vbradnitski vbradnitski self-assigned this Dec 10, 2019
vbradnitski added a commit that referenced this issue Dec 12, 2019
@jsi jsi removed this from the 7.2.0 milestone Dec 12, 2019
vbradnitski added a commit that referenced this issue Dec 13, 2019
vbradnitski added a commit that referenced this issue Dec 13, 2019
vbradnitski added a commit that referenced this issue Dec 16, 2019
vbradnitski added a commit that referenced this issue Dec 17, 2019
vbradnitski added a commit that referenced this issue Dec 17, 2019
vbradnitski added a commit that referenced this issue Dec 17, 2019
ComponentServiceTest
vbradnitski added a commit that referenced this issue Dec 30, 2019
vbradnitski added a commit that referenced this issue Dec 30, 2019
GlennRicaud added a commit that referenced this issue Jan 23, 2020
@alansemenov alansemenov changed the title Component Names Component Names are still present in admin interface May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants