Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize Context attributes in lib-context #7903

Closed
gbbirkisson opened this issue Feb 24, 2020 · 1 comment
Closed

Serialize Context attributes in lib-context #7903

gbbirkisson opened this issue Feb 24, 2020 · 1 comment
Assignees
Labels
Projects
Milestone

Comments

@gbbirkisson
Copy link
Contributor

Context has a map of attributes. When I set attributes in the context I expect to be able to read them, but the ContextMapper does not attempt to serialize them when getting the context from Javascript.

Maybe that is done for a reason because there are objects in the attributes that maybe are not serializable, but it would be nice to have some way to access attributes in javascript that I know are serializable.

@rymsha rymsha added the Bug label Oct 7, 2020
@rymsha rymsha added this to Needs triage in Bugs via automation Oct 7, 2020
@rymsha rymsha moved this from Needs triage to Low priority in Bugs Oct 7, 2020
@rymsha rymsha added this to the 7.6.2 milestone Apr 9, 2021
@rymsha rymsha removed this from the 7.6.2 milestone May 11, 2021
@rymsha rymsha added this to the 7.8.0 milestone Nov 5, 2021
@rymsha rymsha added Feature and removed Bug labels Nov 15, 2021
@rymsha rymsha changed the title ContextMapper in lib-context does not serialize attributes. Serialize Context attributes in lib-context Nov 15, 2021
@rymsha
Copy link
Contributor

rymsha commented Nov 15, 2021

For now we will serialize only types of Number, String, Boolean and MapSerializable. The rest of attributes (for instance of type Date or BranchId) will be swallowed - we may reconsider what else we want to serialize in future.

We'll merge top-level, local, session (in order of preference) attributes into one Map, so it is possible to mimic Java getAttribute call in JS.

@rymsha rymsha removed this from Low priority in Bugs Nov 15, 2021
@rymsha rymsha added this to To do in 7.8.0 via automation Nov 15, 2021
@rymsha rymsha moved this from To do to Done in 7.8.0 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
7.8.0
Done
Development

No branches or pull requests

4 participants