createBranch does not push root node from master to branchId

[ComLock]

When you create a repo, the master branch will be created with a root node.
https://repo.enonic.com/public/com/enonic/xp/docs/7.6.0/docs-7.6.0-libdoc.zip!/module-repo.html#.create

When you create a branch, the root node is not pushed from the master branch unto the branchId
https://repo.enonic.com/public/com/enonic/xp/docs/7.6.0/docs-7.6.0-libdoc.zip!/module-repo.html#.createBranch

When you later try to make a node in the branch, you will get an error because the root path does not exist...

com.enonic.xp.node.NodeNotFoundException: Node with path [/] found in path-cache but not in storage

[rymsha]

This would be breaking if we start doing that, because all existing developer's code will start failing with NodeAlreadyExistAtPathException.
Possible solution: silently ignore attempts to create root node in any branch and make branch creation code responsible to magically assosiate the root node with a branch.

[rymsha]

According to the code root node is always pushed immediately into a created branch.

So, I need an example code, that demonstrates the bug

[rymsha]

could it be related to #9205 ?

[vbradnitski]

Can't reproduce it in master and 7.6.2 with the following code:

    repoLib.createBranch({repoId:'com.enonic.cms.default', branchId:'myBranch'});

    var nodeConnect = nodeLib.connect({
        repoId: 'com.enonic.cms.default',
        branch: 'myBranch'
    });

    nodeConnect.create({
        _name: "myNode",
        _parentPath: "/",
        displayName: "This is brand new node",
        someData: {
            cars: [
                "skoda", "tesla model X"
            ],
            likes: "plywood",
            numberOfUselessGadgets: 123
        }
    });

Most likely it was reproduced in a cluster environment, so an additional 'refresh' operation has been added to improve this case (for master and 7.8 branches).

@ComLock

[rymsha]

We haven't managed to reproduce the problem. Maybe it happens on cluster environments only?

We added extra index refresh. It slows down branch creation a bit, and guarantees that root node existence is newly created branch is visible for sequential node.create calls.