Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Import - Permissions not imported #8725

Closed
GlennRicaud opened this issue Apr 3, 2021 · 0 comments
Closed

Node Import - Permissions not imported #8725

GlennRicaud opened this issue Apr 3, 2021 · 0 comments
Assignees
@vbradnitski
Labels
Bug
Projects
Bugs
Milestone
7.6.2

Comments

@GlennRicaud
Copy link
Contributor

GlennRicaud commented Apr 3, 2021 •
edited

Bug present in version 7.6.0 and 7.6.1.

  • Export a node with custom permissions
    => The node is exported correctly
  • Delete and import the export
    => The node is imported but with incorrect permissions.

Focusing on the existing node import capability (NodeImporter and all the chain up), not the new import content.

Solution 1: includePermissions should have been used for both creation/update and there was a bug in previous versions (that sounds reasonable that update and create should behave the same way)
Use the value of includePermissions to set importPermissionsOnCreate in NodeImporter

Solution 2: Strict backward compatibility
Set com.enonic.xp.node.ImportNodeParams.Builder.importPermissionsOnCreate to true by default

Solution 3: Breaking change with new parameter importPermissionsOnCreate
Add a new parameter importPermissionsOnCreate all the way up to the ExportService and the rest API (+Adapt clients of the related APIs)
@GlennRicaud GlennRicaud changed the title ExportService - ImportNodes - Permissions not imported Node Import - Permissions not imported Apr 3, 2021
@alansemenov alansemenov added the Bug label Apr 7, 2021
@alansemenov alansemenov added this to Needs triage in Bugs via automation Apr 7, 2021
@vbradnitski vbradnitski moved this from Needs triage to High priority in Bugs Apr 8, 2021
@rymsha rymsha added this to the 7.6.2 milestone Apr 8, 2021
vbradnitski added a commit that referenced this issue Apr 22, 2021
@vbradnitski
Node Import - Permissions not imported #8725
33e814e
vbradnitski added a commit that referenced this issue Apr 22, 2021
@vbradnitski
Node Import - Permissions not imported #8725
5e2dc7d
vbradnitski added a commit that referenced this issue Apr 25, 2021
@vbradnitski
Node Import - Permissions not imported #8725
f53eeac
vbradnitski added a commit that referenced this issue Apr 26, 2021
@vbradnitski
Node Import - Permissions not imported #8725
0ae65e0
rymsha pushed a commit that referenced this issue Apr 26, 2021
@vbradnitski @rymsha
Node Import - Permissions not imported #8725
56cd6bf
@rymsha rymsha moved this from High priority to Closed in Bugs Apr 26, 2021
anatol-sialitski pushed a commit that referenced this issue Jul 20, 2021
@vbradnitski @anatol-sialitski
Node Import - Permissions not imported #8725
01f9079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbradnitski vbradnitski

Labels
Bug
Projects
No open projects
Bugs
Closed
Milestone
7.6.2
Development

No branches or pull requests
4 participants
@rymsha @vbradnitski @alansemenov @GlennRicaud