Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VHost improvements #9047

Closed
10 tasks done
rymsha opened this issue Sep 1, 2021 · 2 comments
Closed
10 tasks done

VHost improvements #9047

rymsha opened this issue Sep 1, 2021 · 2 comments
Assignees
@anatol-sialitski
Labels
Epic Feature
Projects
7.8.0
Milestone
7.8.0

Comments

@rymsha
Copy link
Contributor

rymsha commented Sep 1, 2021 •
edited

  • Generify Forwarded-For processing
  • Regular expressions for host
  • Multiple hosts in one VHost
  • Explicit order of VHosts
  • Templating for target (Capture groups)
  • root domain
  • punycode
  • host case insensitivity
  • JS API to get current VHost
  • docs Document VHost Regexp doc-xp#344
@rymsha rymsha added the Epic label Sep 1, 2021
@rymsha rymsha added this to the 7.8.0 milestone Sep 1, 2021
@rymsha rymsha self-assigned this Sep 1, 2021
@rymsha rymsha added this to In progress in 7.8.0 Oct 1, 2021
@rymsha
Copy link
Contributor Author

rymsha commented Oct 1, 2021 •
edited

"root domain" well discussed in curl/curl#716
XP 7.0-7.x requires two vhosts example.com and example.com. we preserve such behavior for backwards compatibility. It differs from ngnix, apache and curl, but with regex and multiple hosts in one vhost functionality - it is simpler to support both hosts with and without trailing dot.

@rymsha rymsha assigned anatol-sialitski and unassigned rymsha Oct 1, 2021
@rymsha
Copy link
Contributor Author

rymsha commented Oct 4, 2021

"punycode". We will write in docs "IDN hosts should be specified using Punycode representation"

This was referenced Oct 6, 2021
Closed
Closed
rymsha added a commit that referenced this issue Oct 8, 2021
@rymsha @anatol-sialitski
VHost improvements #9047 (#9135)
e8530da 
* Vhost improvements (#9087)

Co-authored-by: anatol-sialitski <53557255+anatol-sialitski@users.noreply.github.com>
@rymsha rymsha moved this from In progress to Done in 7.8.0 Oct 20, 2021
rymsha added a commit to enonic/app-booster that referenced this issue Feb 29, 2024
@rymsha
XP does not normalize root domain enonic/xp#9047
f50c033
rymsha added a commit to enonic/app-booster that referenced this issue Feb 29, 2024
@rymsha
XP does not normalize root domain enonic/xp#9047
367014f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Epic Feature
Projects
No open projects
7.8.0
Done
Milestone
7.8.0
Development

No branches or pull requests
3 participants
@rymsha @alansemenov @anatol-sialitski