Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support imageSizes parameter in lib-portal's processHtml #9082

Closed
poi33 opened this issue Sep 16, 2021 · 1 comment
Closed

Support imageSizes parameter in lib-portal's processHtml #9082

poi33 opened this issue Sep 16, 2021 · 1 comment
Assignees
@anatol-sialitski
Labels
Feature
Milestone
7.8.0

Comments

@poi33
Copy link

poi33 commented Sep 16, 2021

https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
"If the srcset attribute is present and has any image candidate strings using a width descriptor, the sizes attribute must also be present"

Not having sizes attribute makes the html element invalid. Even if most browsers still render it and handle it properly.
@rymsha rymsha added the Bug label Sep 16, 2021
@rymsha rymsha added this to Needs triage in Bugs via automation Sep 16, 2021
@rymsha rymsha moved this from Needs triage to Low priority in Bugs Sep 16, 2021
@rymsha rymsha added this to the 7.8.0 milestone Sep 16, 2021
@rymsha rymsha added Feature and removed Bug labels Sep 17, 2021
@rymsha
Copy link
Contributor

rymsha commented Sep 17, 2021

without srcset browser assumes 100vw, some sources say (does not seem to be part of standard thought).
We will add optional imageSizes attribute - string we add to img sizes

@rymsha rymsha changed the title lib-portal srcset is missing the sizes attribute lib-portal srcset sizes attribute support Sep 17, 2021
@rymsha rymsha changed the title lib-portal srcset sizes attribute support lib-portal img sizes attribute support Sep 17, 2021
@rymsha rymsha removed this from Low priority in Bugs Sep 17, 2021
anatol-sialitski added a commit that referenced this issue Sep 17, 2021
@anatol-sialitski
lib-portal img sizes attribute support #9082
488f950
anatol-sialitski added a commit that referenced this issue Sep 17, 2021
@anatol-sialitski
lib-portal img sizes attribute support #9082
a2b9d38
anatol-sialitski added a commit that referenced this issue Sep 20, 2021
@anatol-sialitski
lib-portal img sizes attribute support #9082
0417a58
@alansemenov alansemenov changed the title lib-portal img sizes attribute support Support imageSizes parameter in lib-portal's processHtml Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Feature
Projects
None yet
Milestone
7.8.0
Development

No branches or pull requests
4 participants
@rymsha @poi33 @alansemenov @anatol-sialitski