Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump/Export trimming file name while importing #9094

Closed
rymsha opened this issue Sep 24, 2021 · 2 comments
Closed

Dump/Export trimming file name while importing #9094

rymsha opened this issue Sep 24, 2021 · 2 comments
Assignees
@anatol-sialitski
Labels
Bug
Projects
Bugs
Milestone
7.8.0

Comments

@rymsha
Copy link
Contributor

rymsha commented Sep 24, 2021 •
edited
Loading

https://discuss.enonic.com/t/dump-export-trimming-file-name-while-importing/2607
@rymsha rymsha added the Bug label Sep 24, 2021
@rymsha rymsha added this to Needs triage in Bugs via automation Sep 24, 2021
@rymsha rymsha self-assigned this Sep 24, 2021
@rymsha rymsha moved this from Needs triage to Low priority in Bugs Sep 24, 2021
@rymsha rymsha moved this from Low priority to High priority in Bugs Oct 5, 2021
@rymsha rymsha moved this from High priority to Low priority in Bugs Oct 5, 2021
@rymsha rymsha assigned vbradnitski and unassigned rymsha Nov 5, 2021
@rymsha rymsha moved this from Low priority to High priority in Bugs Nov 5, 2021
@rymsha rymsha added this to the 7.8.0 milestone Nov 5, 2021
anatol-sialitski added a commit that referenced this issue Nov 10, 2021
@anatol-sialitski
Dump/Export trimming file name while importing #9094
39c92a1
anatol-sialitski added a commit that referenced this issue Nov 12, 2021
@anatol-sialitski
Dump/Export trimming file name while importing #9094
f4b8e1d
anatol-sialitski added a commit that referenced this issue Nov 12, 2021
@anatol-sialitski
Dump/Export trimming file name while importing #9094
eb2e88c
@rymsha
Copy link
Contributor Author

rymsha commented Nov 12, 2021

have some similarities with #6475

anatol-sialitski added a commit that referenced this issue Nov 12, 2021
@anatol-sialitski
Dump/Export trimming file name while importing #9094
12204aa
@rymsha
Copy link
Contributor Author

rymsha commented Nov 12, 2021

Calling trim for XML values was handy but not correct in many cases.
We decided to remove global trim and put it where it could make sense

  • do not trim in node import from export (because this file is machine generated)
  • in XML descriptors trim "contentType", "principalKey", etc for backwards compatibility
<allow>
  base:type
</allow>

@rymsha rymsha moved this from High priority to Closed in Bugs Nov 12, 2021
anatol-sialitski added a commit that referenced this issue Nov 15, 2021
@anatol-sialitski
Dump/Export trimming file name while importing #9094
edaab9b
@rymsha rymsha mentioned this issue Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Bug
Projects
No open projects
Bugs
Closed
Milestone
7.8.0
Development

No branches or pull requests
4 participants
@rymsha @vbradnitski @alansemenov @anatol-sialitski