Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default email sender is not working #10404 #10470

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Mar 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 89.35185% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 84.45%. Comparing base (6dc87f3) to head (2d9bbcf).

Files Patch % Lines
.../com/enonic/xp/mail/impl/MimeMessageConverter.java 84.93% 7 Missing and 4 partials ⚠️
.../java/com/enonic/xp/mail/impl/MailServiceImpl.java 63.15% 7 Missing ⚠️
...c/main/java/com/enonic/xp/mail/SendMailParams.java 93.93% 4 Missing ⚠️
...n/java/com/enonic/xp/lib/mail/SendMailHandler.java 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               7.14   #10470      +/-   ##
============================================
- Coverage     84.45%   84.45%   -0.01%     
- Complexity    19504    19536      +32     
============================================
  Files          2599     2603       +4     
  Lines         67841    67988     +147     
  Branches       5394     5397       +3     
============================================
+ Hits          57294    57418     +124     
- Misses         7940     7962      +22     
- Partials       2607     2608       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatol-sialitski anatol-sialitski merged commit 14b7f0e into 7.14 Mar 19, 2024
5 of 6 checks passed
@anatol-sialitski anatol-sialitski deleted the issue-10404-v7.14 branch March 19, 2024 08:19
@anatol-sialitski anatol-sialitski restored the issue-10404-v7.14 branch March 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default email sender is not working
2 participants