Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User with "Users Administrator" rights cannot change a password (#4423) #4469

Merged
merged 2 commits into from
Feb 27, 2017

Conversation

vbradnitski
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 23, 2017

Codecov Report

Merging #4469 into master will decrease coverage by -0.13%.
The diff coverage is 90%.

@@             Coverage Diff              @@
##             master    #4469      +/-   ##
============================================
- Coverage     76.04%   75.91%   -0.13%     
- Complexity    13503    13553      +50     
============================================
  Files          2062     2062              
  Lines         50016    50303     +287     
  Branches       4404     4452      +48     
============================================
+ Hits          38034    38187     +153     
- Misses         9778     9907     +129     
- Partials       2204     2209       +5
Impacted Files Coverage Δ Complexity Δ
.../com/enonic/xp/security/acl/AccessControlList.java 96.49% <100%> (+0.06%) 25 <5> (+1)
...nic/xp/core/impl/security/SecurityInitializer.java 91.27% <88%> (+0.56%) 14 <3> (ø)
...com/enonic/xp/web/impl/context/SessionWrapper.java 8.57% <0%> (-2.8%) 2% <0%> (ø)
...in/impl/rest/resource/content/ContentResource.java 44.12% <0%> (+4.73%) 129% <0%> (+49%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df75d76...0ab71d6. Read the comment docs.

@GlennRicaud
Copy link
Contributor

@vbradnitski I noticed on multiple recent commits from you that you have a different reformatting. It makes reading a bit harder. Could you fix it.

@vbradnitski
Copy link
Contributor Author

hmm, I use the latest codestyle scheme from dev-tools
image
Should I add any additional settings?

@GlennRicaud GlennRicaud merged commit a96eab2 into master Feb 27, 2017
@GlennRicaud GlennRicaud deleted the #4423 branch February 27, 2017 20:59
@GlennRicaud
Copy link
Contributor

You are not the only one apparently. Seems to depend on the IDEA version.
Will mention it tomorrow at the sprint meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants