Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox-poetry-installer crashes due to import error #73

Closed
finswimmer opened this issue Aug 31, 2022 · 3 comments
Closed

tox-poetry-installer crashes due to import error #73

finswimmer opened this issue Aug 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@finswimmer
Copy link

Hey,

we released poetry1.2.0 and poetry-core 1.1.0 today 馃帀 Unfortunately this breaks tox-poetry-installer due to changed import paths.

Most of them can be fixed easily:

from poetry.core.packages import Package as PoetryPackage

from poetry.core.packages.package import Package as PoetryPackage 

and

from poetry.core.packages import Dependency as PoetryDependency
from poetry.core.packages import Package as PoetryPackage

from poetry.core.packages.dependency import Dependency as PoetryDependency
from poetry.core.packages.package import Package as PoetryPackage

But I'm not sure what's the best way to fix

from poetry.io.null_io import NullIO

This is not available anymore in poetry 1.2.0. Instead it's available in the most recent version of cleo:

from cleo.io.null_io import NullIO

While the easy changes are compatible with poetry < 1.2, the change of NullIO import isn't. Maybe just put another try/except in here to find put what's available?

fin swimmer

@enpaul
Copy link
Owner

enpaul commented Sep 6, 2022

Thanks for the report @finswimmer

I've just released version 0.8.5 which pins the Poetry requirement at less than 1.2 to back stop this issue in the immediate time frame. @Callek has a PR up to add support for Poetry 1.2 that I'll be looking at next to hopefully get this functionality added soon

@Callek
Copy link
Contributor

Callek commented Sep 6, 2022

Thanks for the report @finswimmer

I've just released version 0.8.5 which pins the Poetry requirement at less than 1.2 to back stop this issue in the immediate time frame. @Callek has a PR up to add support for Poetry 1.2 that I'll be looking at next to hopefully get this functionality added soon

My pr pins to an alpha of poetry 1.2, but happy to bump that to the final release depending on Ethan's opinion here.

Mostly just blocked on his time

@enpaul
Copy link
Owner

enpaul commented Sep 7, 2022

This issue should now be resolved by #70 , thanks to @Callek

@enpaul enpaul closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants