Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic changes to support poetry 1.2.0, no longer support Poetry 1.1.x #70

Merged
merged 7 commits into from
Sep 7, 2022

Conversation

Callek
Copy link
Contributor

@Callek Callek commented Jul 2, 2022

This adds support for poetry 1.2.0b2 while dropping 1.1.x support.

Might still need some work but seems to be working ok

@Callek Callek force-pushed the callek/poetry-1.2.0b2 branch 8 times, most recently from ee918f5 to acd3f74 Compare July 8, 2022 20:53
@Callek Callek marked this pull request as ready for review July 8, 2022 20:53
@Callek
Copy link
Contributor Author

Callek commented Jul 8, 2022

@enpaul this is now ready for review. Had a CI run over at: https://github.com/Callek/tox-poetry-installer/actions/runs/2638529975

(with a now-dropped commit that added support for CI on my branch for my own fork)

@Callek Callek changed the title Basic changes to support poetry 1.2.0b2, no longer support Poetry 1.1.x Basic changes to support poetry 1.2.0b3, no longer support Poetry 1.1.x Jul 15, 2022
@Callek
Copy link
Contributor Author

Callek commented Jul 15, 2022

@enpaul Updated to support Poetry 1.2.0b3 which was just released.

Copy link

@fsgnil fsgnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for fixing this. I'm also looking to use tox-poetry-installer with peotry 1.2.0. I'm not sure if my approval helps. But hopefully this gets merged soon.

@Mause
Copy link

Mause commented Aug 31, 2022

1.2.0 has now been released, would be great to see this merged to get compatibility with it

@lbenezriravin
Copy link

My spidey senses tell me we'll see a release this coming Tuesday.

@zachtaira
Copy link

@Callek thanks for the PR! Much appreciated

@ctapobep
Copy link

ctapobep commented Sep 7, 2022

Since Poetry 1.2 has been released and it broke backward compatibility 🤦, would be great to expedite this.

Copy link
Owner

@enpaul enpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the legwork here @Callek! There are a few things I highlighted as needing some fixes, but overall it looks good! Really excited to get this merged, and very sorry about the delay!

.github/scripts/setup-env.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox_poetry_installer/constants.py Show resolved Hide resolved
tox_poetry_installer/utilities.py Outdated Show resolved Hide resolved
@Callek Callek requested a review from enpaul September 7, 2022 16:06
@enpaul enpaul changed the title Basic changes to support poetry 1.2.0b3, no longer support Poetry 1.1.x Basic changes to support poetry 1.2.0, no longer support Poetry 1.1.x Sep 7, 2022
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox_poetry_installer/__about__.py Outdated Show resolved Hide resolved
tox_poetry_installer/utilities.py Show resolved Hide resolved
Copy link
Owner

@enpaul enpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@enpaul enpaul merged commit 12c4ec6 into enpaul:devel Sep 7, 2022
andreoliwa added a commit to andreoliwa/nitpick that referenced this pull request Sep 18, 2022
andreoliwa added a commit to andreoliwa/logseq-doctor that referenced this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants