-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic changes to support poetry 1.2.0, no longer support Poetry 1.1.x #70
Conversation
ee918f5
to
acd3f74
Compare
acd3f74
to
53eb007
Compare
@enpaul this is now ready for review. Had a CI run over at: https://github.com/Callek/tox-poetry-installer/actions/runs/2638529975 (with a now-dropped commit that added support for CI on my branch for my own fork) |
53eb007
to
d9be6da
Compare
@enpaul Updated to support Poetry 1.2.0b3 which was just released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for fixing this. I'm also looking to use tox-poetry-installer with peotry 1.2.0. I'm not sure if my approval helps. But hopefully this gets merged soon.
1.2.0 has now been released, would be great to see this merged to get compatibility with it |
My spidey senses tell me we'll see a release this coming Tuesday. |
@Callek thanks for the PR! Much appreciated |
Since Poetry 1.2 has been released and it broke backward compatibility 🤦, would be great to expedite this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the legwork here @Callek! There are a few things I highlighted as needing some fixes, but overall it looks good! Really excited to get this merged, and very sorry about the delay!
… to [tool.poetry.dev-dependencies]
…htly improve speed.
Bump action versions, use poetry 1.2.0b2, Use py310 for static tests, Use better naming for python tests.
b711636
to
2a2afc3
Compare
2a2afc3
to
c9d0203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing 🎉
c9d0203
to
eb70075
Compare
…ther than pre-release.
eb70075
to
73ddd43
Compare
This adds support for poetry 1.2.0b2 while dropping 1.1.x support.
Might still need some work but seems to be working ok